Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(*): remove unnecessary optional attributes #1802

Merged
merged 2 commits into from
Jul 1, 2024
Merged

perf(*): remove unnecessary optional attributes #1802

merged 2 commits into from
Jul 1, 2024

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jul 1, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@cipchk
Copy link
Member Author

cipchk commented Jul 1, 2024

Preview Build Failed!

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.87%. Comparing base (42a4250) to head (7952279).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1802      +/-   ##
==========================================
+ Coverage   94.82%   94.87%   +0.05%     
==========================================
  Files         315      315              
  Lines        8912     8902      -10     
  Branches     1796     1789       -7     
==========================================
- Hits         8451     8446       -5     
+ Misses        383      381       -2     
+ Partials       78       75       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cipchk cipchk merged commit b9b36d6 into master Jul 1, 2024
8 of 9 checks passed
@cipchk cipchk deleted the perf-direct branch July 1, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant